Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: time field issue in edit batch form #1107

Closed
wants to merge 2 commits into from

Conversation

iamejaaz
Copy link
Contributor

@iamejaaz iamejaaz commented Nov 8, 2024

Closes #1103

Before

image

After

image

Copy link

cypress bot commented Nov 8, 2024

lms    Run #796

Run Properties:  status check passed Passed #796  •  git commit 4f2d21f107 ℹ️: Merge 5febe9e9bdf6576684177cd3b1c6608b662640c3 into c5f091fae8a6bb588fcf06b66e8f...
Project lms
Branch Review time-field-issue
Run status status check passed Passed #796
Run duration 00m 30s
Commit git commit 4f2d21f107 ℹ️: Merge 5febe9e9bdf6576684177cd3b1c6608b662640c3 into c5f091fae8a6bb588fcf06b66e8f...
Committer Ejaaz Khan
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1
View all changes introduced in this branch ↗︎

@pateljannat
Copy link
Collaborator

@iamejaaz I don't understand the issue you are trying to solve here. The time field works properly currently. What exactly is the issue you are facing?

Screenshot 2024-11-12 at 11 58 28 AM

@iamejaaz
Copy link
Contributor Author

@iamejaaz I don't understand the issue you are trying to solve here. The time field works properly currently. What exactly is the issue you are facing?

@pateljannat Please try selecting an AM time and check, as I showed the issue in the video. When I select an AM time, like 12 AM or 1 AM, it does not display in the edit form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

time field issue in edit batch form
2 participants