Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-detecting filetype by inspecting the video url breaks when a plugin specifies a mimetype that is not associated with a file extension #27

Open
mike-tomko-codebaby opened this issue Feb 6, 2014 · 0 comments
Labels

Comments

@mike-tomko-codebaby
Copy link

While using this library in Firefox for Ubuntu I noticed that filetype auto-detection by video url breaks because the Totem Player Firefox plugin (named VLC Multimedia Plugin (compatible Totem 3.0.1)), specifies one or more mimetypes with a blank suffix (aka file extension). This leads to an incorrect typeModel being loaded which ends with error number 11 Invalid streamType and/or streamServer settings for null.

One question I have is why is _getTypeFromFileExtension() ran if we already have the type? Up until the _getTypeFromFileExtension() function is ran, the file object has both a src (String) and a type (String) property. Why is this type ignored in favor of what _getTypeFromFileExtension() returns, and why is the returned type added to src by making it an object? What is the use of data.file.type if data.file.src.type is used for finding the correct typesModel? (for reference, the code block I'm talking about is located here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants