Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elastic Search v6.x support? #12

Open
robvolk opened this issue Aug 12, 2018 · 4 comments
Open

Elastic Search v6.x support? #12

robvolk opened this issue Aug 12, 2018 · 4 comments

Comments

@robvolk
Copy link

robvolk commented Aug 12, 2018

I'm trying to use this with ES v6.x, but I can't get it to install. What's needed to get this to work with ES6? Thanks a ton - this filter is exactly what I need.

@bomberby
Copy link
Collaborator

I have not used ES 6 yet, but i'd suggest starting from https://github.com/bomberby/elasticsearch-concatenate-token-filter/commits/es-5.2.0, as most of the changes for 5.2 are there in that commit, I'm not sure if they changed any of the plugins mechanism.

For starters, the most likely things that needs to be done:

Change relevant ES versions in following files:

pom.xml
plugin-descriptor.properties
target/classes/es-plugin.properties

If any major change was done to ES way of writing plugins, these will need to change as well, please look at example plugins run mvn clean install and copy result files from target/releases to root for easier linking

@robvolk
Copy link
Author

robvolk commented Aug 14, 2018

Oh great! Thanks for pointing me in the right direction @bomberby.

@robvolk
Copy link
Author

robvolk commented Aug 18, 2018

After I change the version info, how do I build it? Don't have any experience with the ES plugin ecosystem.

@bomberby
Copy link
Collaborator

You should use maven to build, i think running mvn clean install from the project root directory will create the files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants