Add compile time completion generation #328
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is looking wonderful, thank you so much! I'm not that familiar with Apart from that, everything you've said about distribution and documentation sounds really good! Is the elegance of a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds completions that are generated at compile time and stored under the perseus-cli package in version control.
Fulfulls feature request #325.
TBD is deciding the story on distribution and writing up documentation.
@arctic-hen7 I would suggest we add the files to the automated GitHub release. Instructions would instruct users to download the file, copy to a sensible location, and update the shell environment files appropriately, with a subsection for each supported shell.
If you I agree I can handle adding that to the CD workflow and write up the completion installation as a addendum to the existing "Installing Perseus" page.