Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAC is silently ignored, but reports success, when no permissions granted #160

Open
d-g opened this issue Oct 30, 2024 · 1 comment
Open

Comments

@d-g
Copy link

d-g commented Oct 30, 2024

(Carry over from #155 (comment))

Steps to repoduce:

  • install FoxyProxy, but does not grant it incognito-mode access;
  • configure a PAC profile;
  • activate it.

Actual result:
icon shows [PAC], as if user command is successfully executed; while is is not, it is just ignored:

// Incognito Access
const allowed = await browser.extension.isAllowedIncognitoAccess();
if (!allowed) { return; }

Expected result:
an error message?

@erosman
Copy link
Collaborator

erosman commented Oct 30, 2024

Originally, code was written a hard error when incognito access was not given.
It was later changed to allow users to create a config which can be shared (exported or synced).
Every time options page is opened, there is an alert().

// ---------- Incognito Access -----------------------------
class IncognitoAccess {
static {
// https://developer.mozilla.org/docs/Mozilla/Add-ons/WebExtensions/API/proxy/settings
// Changing proxy settings requires private browsing window access because proxy settings affect private and non-private windows.
// https://github.com/w3c/webextensions/issues/429
// Inconsistency: incognito in proxy.settings
// https://bugzilla.mozilla.org/show_bug.cgi?id=1725981
// proxy.settings is not supported on Android
App.firefox && App.hasProxySettings && browser.extension.isAllowedIncognitoAccess()
.then(response => !response && alert(browser.i18n.getMessage('incognitoAccessError')));
}
}
// ---------- /Incognito Access ----------------------------

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants