Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(Coverage): forge coverage --report lcov is failing after the latest release #5609

Closed
2 tasks done
jalextowle opened this issue Aug 11, 2023 · 6 comments
Closed
2 tasks done
Labels
T-bug Type: bug

Comments

@jalextowle
Copy link

Component

Forge

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

Run forge --version forge 0.2.0 (3fec8c1 2023-08-11T00:15:50.024503184Z)

What command(s) is the bug in?

forge coverage

Operating System

Linux

Describe the bug

forge coverage --report lcov runs for 6 hours before our CI actions are timing out. I'm posting screenshots from before and after the new release dropped. Prior to the new release, we never had issues with our code coverage action, but since the release, every coverage job has run for 6 hours and failed due to a timeout.

Here's a screenshot showing our recent job statuses:
Screen Shot 2023-08-11 at 10 29 46 AM

I looked at the release history, and the latest release coincides with this.
Screen Shot 2023-08-11 at 10 18 39 AM

I downgraded to version forge 0.2.0 (1044042 2023-08-10T13:04:25.942019017Z), and sure enough, the coverage job succeeds:

Screen Shot 2023-08-11 at 10 38 38 AM

Downgrading is an easy fix for us in the meantime, but let me know if there's any other information that would be helpful when investigating this. Unfortunately, our repo is private at the moment, so I don't have an example to point to.

@jalextowle jalextowle added the T-bug Type: bug label Aug 11, 2023
@gakonst gakonst added this to Foundry Aug 11, 2023
@github-project-automation github-project-automation bot moved this to Todo in Foundry Aug 11, 2023
@jalextowle jalextowle changed the title bug(Coverage): forge coverage --report lcov is failing after the latest release in Ubuntu CI builds bug(Coverage): forge coverage --report lcov is failing after the latest release Aug 11, 2023
@matbour
Copy link

matbour commented Aug 11, 2023

I can confirm this bug on my company's smart contract repository. See relevant action run.

@arr00
Copy link

arr00 commented Aug 11, 2023

Actions broke on my repo as well. Reran past actions that succeeded and they fail now.

@Evalir
Copy link
Member

Evalir commented Aug 11, 2023

Hey all! this is a result of revm upgrades we recently did—we're rolling out a fix soon: #5610

@matbour
Copy link

matbour commented Aug 15, 2023

Issue seems to be solved in my CI

@0xTimepunk
Copy link

@Evalir the issue has returned today on our CI, can you please verify?

@Evalir
Copy link
Member

Evalir commented Aug 23, 2023

Closed with #5695 and #5698

@Evalir Evalir closed this as completed Aug 23, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Foundry Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bug Type: bug
Projects
Archived in project
Development

No branches or pull requests

5 participants