Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions for improvements #37

Open
vlbee opened this issue Aug 6, 2018 · 1 comment
Open

Suggestions for improvements #37

vlbee opened this issue Aug 6, 2018 · 1 comment
Assignees

Comments

@vlbee
Copy link
Member

vlbee commented Aug 6, 2018

This workshop is challenging conceptually and there is a lot of code to get through. @tdoran and I would like to make a couple possible suggestions for future mentors/cohorts.

During our mentoring of FAC14, hardly any pairs got past Approach 1 in the exercises. We feel it is important students have time to try and compare all three approaches during this workshop.

Suggestions:

  1. Remove the Stretch Goal functions from each approach into a separate folder - we notice students often are tempted to try to complete the stretch goal if they see it there, even when told not too.

  2. Suggest an alternative approach for tackling the workshop - complete the first function for all 3 approaches and then pause for sharing answers, then complete the second function for all 3 approaches, etc. This way you can can discuss the three error handling approaches and all students will have tried at least one small exercise in each.

@oliverjam
Copy link

It might even be worth dropping Approach 3 entirely, given I doubt many cohorts ever get onto it.

I have to say I've never seen (or even heard of) anyone returning error objects and error-handling with instanceof. Fully accept my experience may be limited here though 🤷‍♂️. Seems like an even less common pattern in a world with promises/async functions too

It seems like a bad idea in a lot of scenarios so maybe it's edge-case enough to drop so we can focus better on the two common patterns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants