From 2e530a418b47ef37153bb98be2d112d6623f9b20 Mon Sep 17 00:00:00 2001 From: Ruud Senden <8635138+rsenden@users.noreply.github.com> Date: Sat, 11 May 2024 11:31:59 +0200 Subject: [PATCH] Add TODO comment --- .../cli/common/action/model/SupportedSchemaVersion.java | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/fcli-core/fcli-common/src/main/java/com/fortify/cli/common/action/model/SupportedSchemaVersion.java b/fcli-core/fcli-common/src/main/java/com/fortify/cli/common/action/model/SupportedSchemaVersion.java index 83abe5bd87..2bb4047dec 100644 --- a/fcli-core/fcli-common/src/main/java/com/fortify/cli/common/action/model/SupportedSchemaVersion.java +++ b/fcli-core/fcli-common/src/main/java/com/fortify/cli/common/action/model/SupportedSchemaVersion.java @@ -17,6 +17,13 @@ import lombok.SneakyThrows; +// TODO The approach below won't work. For example, when an action developer uses +// schema version 1.1, the schemaVersion property may be set to either 1.0 or 1.1, +// with schemaVersion 1.0 purposely being supported by older fcli versions. However, +// even when set to 1.0, the schema/IDE will also allow properties that were +// introduced in schema version 1.1, making the action incompatible with older fcli +// versions that only support schema version 1.0. +// // We'll probably need to think about this a bit more, but for now, the // SupportedSchemaVersion enum lists schema versions supported by this fcli version. // The JsonProperty annotations on the enum entries define the actual version numbers,