Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ML-KEM implementations are constant-time #14

Merged
merged 1 commit into from
Feb 7, 2024
Merged

ML-KEM implementations are constant-time #14

merged 1 commit into from
Feb 7, 2024

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Feb 6, 2024

This also adds CI jobs that actually run the checker.

I’ve used the -infer mode to avoid polluting the function signatures with #public annotations.

I’ve added declassification annotations in the rejection sampling loop.

@vbgl vbgl marked this pull request as draft February 6, 2024 10:42
@vbgl vbgl marked this pull request as ready for review February 6, 2024 13:02
@vbgl
Copy link
Contributor Author

vbgl commented Feb 6, 2024

CI job: https://github.com/vbgl/hakyber/actions/runs/7798598482/job/21267625779

@vbgl vbgl merged commit 4f85573 into formosa-crypto:master Feb 7, 2024
2 checks passed
@vbgl vbgl deleted the constant-time branch February 7, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgregoir bgregoir bgregoir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vbgl @bgregoir