FIO-9201: Fix DataTable in quick inline embed issues #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikekotikov
force-pushed
the
fix/FIO-9201_quick_inline_embed
branch
from
a64df9c to
97bdca1
Compare
johnformio
requested changes
Oct 22, 2024
| polling: boolean = false, | ||
| onload?: (ready: Promise<any>) => void, | ||
| ) { | ||
| static requireLibrary(name: string, property: string, src: string | Array<string>, polling: boolean = false, onload?: (ready: Promise<any>) => void, rootElement?: HTMLElement ) { |
There was a problem hiding this comment.
update jsdocs with new parameter
johnformio
reviewed
Oct 22, 2024
Comment on lines
+113
to
+121
| if (rootElement) { | ||
| rootElement.insertAdjacentElement('afterend', element); | ||
| return; | ||
| } | ||
| const { head } = document; | ||
| if (head) { | ||
| head.appendChild(element); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Could this attach the element twice?
There was a problem hiding this comment.
No, since there's a flag in requireLibrary function hasResourceBeenAdded, that would prevent attaching the resource twice
johnformio
approved these changes
Oct 23, 2024
lane-formio
pushed a commit
that referenced
this pull request
Oct 29, 2024
* FIO-9201: Fix quick inline embed issues * FIO-9201: Add small fix * FIO-9201: Add new parameter into jsdocs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-9201
Description
What changed?
Added possibility to pass DOM element relative to which the script should be inserted, since inline embed uses Shadow Root element and scripts should be applied inside of it to work.
Why have you chosen this solution?
Use this section to justify your choices
Breaking Changes / Backwards Compatibility
Use this section to describe any potentially breaking changes this PR introduces or any effects this PR might have on backwards compatibility
Dependencies
formio/premium
How has this PR been tested?
Manually, since premium module is needed to reproduce failing scenario
Checklist: