diff --git a/ramls/circulation-settings.raml b/ramls/circulation-settings.raml index 9af4023eac..731b9187c6 100644 --- a/ramls/circulation-settings.raml +++ b/ramls/circulation-settings.raml @@ -86,14 +86,14 @@ resourceTypes: type: circulation-setting responses: 204: - description: "Circulation settings have been saved." + description: "Circulation settings have been saved" 500: description: "Internal server error" body: text/plain: example: "Internal server error" delete: - is: [ validate ] + is: [validate] responses: 204: description: "Circulation settings deleted" diff --git a/src/main/java/org/folio/circulation/infrastructure/storage/CirculationSettingsRepository.java b/src/main/java/org/folio/circulation/infrastructure/storage/CirculationSettingsRepository.java index e193484698..8125f1761b 100644 --- a/src/main/java/org/folio/circulation/infrastructure/storage/CirculationSettingsRepository.java +++ b/src/main/java/org/folio/circulation/infrastructure/storage/CirculationSettingsRepository.java @@ -39,7 +39,6 @@ public CompletableFuture> getById(String id) { } public CompletableFuture>> findBy(String query) { - return circulationSettingsStorageClient.getManyWithRawQueryStringParameters(query) .thenApply(flatMapResult(response -> MultipleRecords.from(response, CirculationSetting::from, RECORDS_PROPERTY_NAME))); diff --git a/src/main/java/org/folio/circulation/resources/CirculationSettingsResource.java b/src/main/java/org/folio/circulation/resources/CirculationSettingsResource.java index d2bc614511..8e9cc35da7 100644 --- a/src/main/java/org/folio/circulation/resources/CirculationSettingsResource.java +++ b/src/main/java/org/folio/circulation/resources/CirculationSettingsResource.java @@ -41,7 +41,7 @@ void create(RoutingContext routingContext) { final var incomingRepresentation = routingContext.body().asJsonObject(); setRandomIdIfMissing(incomingRepresentation); final var circulationSetting = CirculationSetting.from(incomingRepresentation); - log.debug("replace:: Creating circulation setting: {}", circulationSetting); + log.debug("create:: Creating circulation setting: {}", () -> circulationSetting); ofAsync(circulationSetting) .thenApply(refuseWhenCirculationSettingIsInvalid()) @@ -59,7 +59,7 @@ void replace(RoutingContext routingContext) { final var incomingRepresentation = routingContext.body().asJsonObject(); final var circulationSetting = CirculationSetting.from(incomingRepresentation); - log.debug("replace:: Replacing circulation setting : {}", circulationSetting); + log.debug("replace:: Replacing circulation setting : {}", () -> circulationSetting); ofAsync(circulationSetting) .thenApply(refuseWhenCirculationSettingIsInvalid())