Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Littleskin response parse issue #187

Open
1 task done
JinyiSa opened this issue Aug 31, 2024 · 2 comments
Open
1 task done

Littleskin response parse issue #187

JinyiSa opened this issue Aug 31, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@JinyiSa
Copy link

JinyiSa commented Aug 31, 2024

Operating System

Windows

Version of PollyMC

PollyMC 8.0

Version of Qt

Qt 6.6.0

Description of bug

Can't login via littleskin api.And I try to capture the traffic via fiddler, littleskin seems returned a completey valid success response. Here is what I've captured:
捕获

Steps to reproduce

Login an multi-profile littleskin account(Maybe single-profile one will reproduce this too?)

Suspected cause

After reading the code of PollyMC I found the real problem isn't the parsing, but the response of littleskin. It doesn't contains the key "selectedProfile", which causes the problem. Will PollyMC add a UI to select profile like PCL or HMCL?

This issue is unique

  • I have searched the issue tracker and did not find an issue describing my bug.
@evan-goode
Copy link
Contributor

The problem looks limited to multi-profile LittleSkin accounts.

It doesn't contains the key "selectedProfile", which causes the problem

The official authlib-injector docs do suggest returning a selectedProfile when logging in, so it's true that this is partially Blessing Skin's fault (LittleSkin is based on Blessing Skin). I found this upstream issue: bs-community/blessing-skin-plugins#123 (Google translated to English).

Will PollyMC add a UI to select profile like PCL or HMCL?

I've filed an issue in my PollyMC fork to track this: unmojang/FjordLauncher#29.

@JinyiSa
Copy link
Author

JinyiSa commented Sep 14, 2024

The problem looks limited to multi-profile LittleSkin accounts.

It doesn't contains the key "selectedProfile", which causes the problem

The official authlib-injector docs do suggest returning a selectedProfile when logging in, so it's true that this is partially Blessing Skin's fault (LittleSkin is based on Blessing Skin). I found this upstream issue: bs-community/blessing-skin-plugins#123 (Google translated to English).

Will PollyMC add a UI to select profile like PCL or HMCL?

I've filed an issue in my PollyMC fork to track this: unmojang/FjordLauncher#29.

Actually,I made a simple work around by just selecting the first available profile. Maybe these days I'll fix this after learning some Qt things.

@JinyiSa JinyiSa closed this as not planned Won't fix, can't repro, duplicate, stale Sep 14, 2024
@JinyiSa JinyiSa reopened this Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants