Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token key passed as parameter in customClasses #261

Open
vipulvkp opened this issue Jul 24, 2020 · 0 comments
Open

Token key passed as parameter in customClasses #261

vipulvkp opened this issue Jul 24, 2020 · 0 comments

Comments

@vipulvkp
Copy link

vipulvkp commented Jul 24, 2020

value of token key passed under customClasses for Tokenizer is being used as the className for Token component and also for the tag that renders with a close action.

This is wrong . same class name will be used for both parent and child which screws up the design.
Please separate them.

https://github.com/fmoo/react-typeahead/blob/master/src/tokenizer/token.js

https://github.com/wookiehangover/react-typeahead who has forked your original repo has hardcoded the className of
to typeahead-token-close in https://github.com/wookiehangover/react-typeahead/blob/master/src/tokenizer/token.js.

please make this change in your repo as well or accept the change through a PR.

Update: Raised a PR. #262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant