Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check input file sanity in Reader::open #25

Merged
merged 3 commits into from
Jun 30, 2017
Merged

Check input file sanity in Reader::open #25

merged 3 commits into from
Jun 30, 2017

Conversation

sandroos
Copy link
Contributor

@sandroos sandroos commented Jun 8, 2017

In reference to issue #24

sandroos added 3 commits May 17, 2017 18:58
vlsv::Writer::setWriteOnMasterOnly can be used to set or unset the
file I/O mode. If master-only mode is set, then data is gathered to
master process first, and written to output file using master process
only. Otherwise data is written using collective MPI.
open input file. Specific error message can be queried with
vlsv::Reader::getErrorString().
@sandroos
Copy link
Contributor Author

sandroos commented Jun 8, 2017

Ping @galfthan @ykempf

@ykempf
Copy link
Contributor

ykempf commented Jun 9, 2017

This guy works for us. But it includes also the writeArrayMaster commits, I'll try to check whether the files written with that activated are sane.

@sandroos
Copy link
Contributor Author

Oh, I created this branch from wrong master, that's what you get for not using git for couple years...

@ykempf
Copy link
Contributor

ykempf commented Jun 30, 2017

Right, I found a file written with vlsvWriter.setWriteOnMasterOnly(true); on Marconi and indeed it is a sane vlsv file opened with VisIt. It reports 16 procs only, which corresponds to the number of procs on one node (I ran on 100 nodes). So although this did not completely fix our issues (we are talking to the Italians about that), it seems to be doing what we were after here in a correct way.

@sandroos sandroos merged commit b4dac5f into master Jun 30, 2017
@sandroos sandroos deleted the check_open branch October 15, 2017 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants