Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always print traceback #2963

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Always print traceback #2963

wants to merge 2 commits into from

Conversation

pingsutw
Copy link
Member

Tracking issue

NA

Why are the changes needed?

It’s difficult to identify which function failed when encountering a gRPC error

What changes were proposed in this pull request?

Always print the traceback after we get a grpc error.

How was this patch tested?

Raise a grpc error in the create_execution method in raw.py

Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.79%. Comparing base (f938661) to head (8cf8c6d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2963      +/-   ##
==========================================
+ Coverage   75.14%   82.79%   +7.64%     
==========================================
  Files         200        3     -197     
  Lines       20919      186   -20733     
  Branches     2692        0    -2692     
==========================================
- Hits        15720      154   -15566     
+ Misses       4445       32    -4413     
+ Partials      754        0     -754     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wild-endeavor wild-endeavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me test this next time i see an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants