Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update agent uri format #1861

Merged
merged 4 commits into from
Oct 1, 2023
Merged

Conversation

hhcs9527
Copy link
Contributor

@hhcs9527 hhcs9527 commented Sep 29, 2023

TL;DR

  1. Update agent uri format
  2. update the read private key with .pem

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Flyte Agent Ecosystem

@hhcs9527
Copy link
Contributor Author

Hi @pingsutw,
I finished the code change to support multiple protocols and fixed the URI.
Please take a look, thanks.

@hhcs9527
Copy link
Contributor Author

Hi @pingsutw,
I finished fixing the URI.

I will create the new PR to support the new URI.
new URI: uri="snowflake://dummy_user:dummy_account/dummy_warehouse/dummy_database/dummy_schema/dummy_table

Please take a look, thanks a lot!

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a183186) 54.97% compared to head (e19fcd1) 55.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1861      +/-   ##
==========================================
+ Coverage   54.97%   55.00%   +0.02%     
==========================================
  Files         296      296              
  Lines       22231    22254      +23     
  Branches     2167     3350    +1183     
==========================================
+ Hits        12222    12241      +19     
+ Misses       9860     9850      -10     
- Partials      149      163      +14     
Files Coverage Δ
...tekit-snowflake/flytekitplugins/snowflake/agent.py 89.87% <100.00%> (ø)
plugins/flytekit-snowflake/tests/test_agent.py 100.00% <ø> (ø)

... and 24 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pingsutw pingsutw merged commit 2f7073d into flyteorg:master Oct 1, 2023
68 checks passed
Future-Outlier pushed a commit to Future-Outlier/flytekit that referenced this pull request Oct 3, 2023
Signed-off-by: HH <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants