-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add encoder/decoder in structureDataset for snowflake. #1811
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1811 +/- ##
==========================================
+ Coverage 54.33% 54.84% +0.51%
==========================================
Files 288 295 +7
Lines 21934 22282 +348
Branches 3344 3357 +13
==========================================
+ Hits 11917 12221 +304
- Misses 9855 9902 +47
+ Partials 162 159 -3 ☔ View full report in Codecov by Sentry. |
Hi @pingsutw , just finished add ingencoder/decoder in structureDataset for snowflake and unit test, please approve the testing and take a look. |
Hi @pingsutw, please approve the CI test. |
7fac349
to
09052cb
Compare
Hi @pingsutw, please approve the CI test. |
Hi @pingsutw, just finished the changes, Please take a look. |
Hi @pingsutw, just finished the changes to get, please review. |
Hi @pingsutw, just finished the changes to get, please review. |
Signed-off-by: HH <[email protected]>
Signed-off-by: HH <[email protected]>
Signed-off-by: HH <[email protected]>
Signed-off-by: HH <[email protected]>
Signed-off-by: HH <[email protected]>
Signed-off-by: HH <[email protected]>
Signed-off-by: HH <[email protected]>
Signed-off-by: HH <[email protected]>
Signed-off-by: HH <[email protected]>
Signed-off-by: HH <[email protected]>
13c6d5b
to
ba3d2fc
Compare
Signed-off-by: HH <[email protected]>
Signed-off-by: HH <[email protected]>
Signed-off-by: HH <[email protected]>
Hi @pingsutw, I will create the new PR to support the new URI. Thanks a lot |
Signed-off-by: HH <[email protected]>
Signed-off-by: HH <[email protected]>
Signed-off-by: HH <[email protected]>
This is done by other PR, so I'm going to close it, thank you @hhcs9527 ! |
TL;DR
we can add them here, the default is a list of additional protocols, like the following.
Type
Are all requirements met?
Complete description
Example code for user, we can parse the uro with the following format of uri,
"snowflake://{dummy_user}:{dummy_account}/{dummy_warehouse}/{dummy_database}/{dummy_schema}/{dummy_table}"
Tracking Issue
Flyte Agent Ecosystem