Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to Binary input/output type #291

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

andresgomezfrr
Copy link
Collaborator

@andresgomezfrr andresgomezfrr commented Apr 17, 2024

TL;DR

Add support to Binary scalar type.

Type

  • Bug Fix
  • Feature
  • Plugin

Test

  • Workflow
    builder.apply(
      new TestTask,
      Data(
        SdkJavaBindingDataFactory.of("testStr"),
        SdkJavaBindingDataFactory.of(Binary.builder().tag("tag").value("testBinary".getBytes()).build())
      )
    )
  • Task
case class Data(str: SdkBindingData[String], b: SdkBindingData[Binary])
class TestTask extends SdkRunnableTask[Data, Data](SdkScalaType[Data], SdkScalaType[Data]) {
  override def run(input: Data): Data = {
    Data(
      str = SdkBindingDataFactory.of(new String(input.b.get().value())),
      b = SdkBindingDataFactory.of(
        Binary.builder().tag("tag").value(input.str.get().getBytes()).build()
      )
    )
  }
}
Screenshot 2024-04-17 at 18 15 55 Screenshot 2024-04-17 at 18 16 02

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Signed-off-by: Andres Gomez Ferrer <[email protected]>
@andresgomezfrr andresgomezfrr marked this pull request as ready for review April 17, 2024 16:10
@RRap0so RRap0so merged commit 6c2a1a9 into master Apr 18, 2024
4 checks passed
@RRap0so RRap0so deleted the add-binary-support branch April 18, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants