Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Align sd code lines with Flytesnacks example #6063

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JiangJiaWei1103
Copy link
Contributor

@JiangJiaWei1103 JiangJiaWei1103 commented Nov 30, 2024

Tracking issue

Why are the changes needed?

Code snippets on this page are out of sync of this Flytesnacks example after recent transition from rli to literalinclude.

What changes were proposed in this pull request?

Align code snippets on the doc page with the corresponding example.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

#6008

Docs link

https://flyte--6063.org.readthedocs.build/en/6063/user_guide/data_types_and_io/structureddataset.html

Signed-off-by: JiaWei Jiang <[email protected]>
Copy link

codecov bot commented Nov 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.10%. Comparing base (be4d009) to head (a01b520).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6063      +/-   ##
==========================================
- Coverage   37.10%   37.10%   -0.01%     
==========================================
  Files        1318     1318              
  Lines      132326   132326              
==========================================
- Hits        49100    49094       -6     
- Misses      78954    78960       +6     
  Partials     4272     4272              
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.07% <ø> (-0.03%) ⬇️
unittests-flytecopilot 30.99% <ø> (ø)
unittests-flytectl 62.29% <ø> (ø)
unittests-flyteidl 7.23% <ø> (ø)
unittests-flyteplugins 53.82% <ø> (ø)
unittests-flytepropeller 42.63% <ø> (ø)
unittests-flytestdlib 57.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

1 participant