Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flyteadmin][API] get control plane version #5934

Merged
merged 4 commits into from
Nov 5, 2024

Conversation

Future-Outlier
Copy link
Member

@Future-Outlier Future-Outlier commented Oct 29, 2024

Tracking issue

#5318

Why are the changes needed?

provide version api for users.

What changes were proposed in this pull request?

add a method get_control_plane_version in class SynchronousFlyteClient(_RawSynchronousFlyteClient).

How was this patch tested?

local and integration test.

Setup process

from flytekit.configuration import PlatformConfig
from flytekit.clients.friendly import SynchronousFlyteClient as _SynchronousFlyteClient
config = PlatformConfig(endpoint="localhost:30080", insecure=True)
client = _SynchronousFlyteClient(config)
print("Control Plane Version:", client.get_control_plane_version())

Screenshots

Unknown version
image

Know Version
image

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@Future-Outlier Future-Outlier changed the title Gate feature(msgpack IDL) by checking backend version [WIP] Gate feature(msgpack IDL) by checking backend version Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.80%. Comparing base (2b0af2b) to head (6394439).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5934      +/-   ##
==========================================
- Coverage   36.84%   36.80%   -0.05%     
==========================================
  Files        1309     1310       +1     
  Lines      130994   131037      +43     
==========================================
- Hits        48271    48234      -37     
- Misses      78533    78617      +84     
+ Partials     4190     4186       -4     
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.02% <ø> (-0.09%) ⬇️
unittests-flytecopilot 11.73% <ø> (ø)
unittests-flytectl 62.39% <ø> (-0.06%) ⬇️
unittests-flyteidl 6.92% <ø> (ø)
unittests-flyteplugins 53.64% <ø> (ø)
unittests-flytepropeller 42.90% <ø> (-0.12%) ⬇️
unittests-flytestdlib 55.41% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Future-Outlier Future-Outlier changed the title [WIP] Gate feature(msgpack IDL) by checking backend version [flyteadmin][API] get control plane version Nov 5, 2024
Signed-off-by: Future-Outlier <[email protected]>
@Future-Outlier Future-Outlier enabled auto-merge (squash) November 5, 2024 16:42
@Future-Outlier Future-Outlier merged commit 5471608 into master Nov 5, 2024
50 of 51 checks passed
@Future-Outlier Future-Outlier deleted the gate-feature-by-checking-backend-version branch November 5, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants