Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync client should call CloseSend when done sending #5884

Merged

Conversation

RRap0so
Copy link
Contributor

@RRap0so RRap0so commented Oct 22, 2024

Tracking issue

Closes #5885

Why are the changes needed?

The Grpc client never closes send so the server is unable to move forward in the grpc streaming onComplete method. This change will inform the server that is done sending so it can properly move to the next step.

What changes were proposed in this pull request?

Move the closeSend after sending all the necessary things.

How was this patch tested?

Unit test

Setup process

Screenshots

Screenshot 2024-10-22 at 11 29 33

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 36.71%. Comparing base (197ae13) to head (587e39d).
Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
...yteplugins/go/tasks/plugins/webapi/agent/plugin.go 0.00% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5884      +/-   ##
==========================================
+ Coverage   34.48%   36.71%   +2.23%     
==========================================
  Files        1138     1304     +166     
  Lines      102742   130081   +27339     
==========================================
+ Hits        35434    47764   +12330     
- Misses      63634    78147   +14513     
- Partials     3674     4170     +496     
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (+0.21%) ⬆️
unittests-flyteadmin 54.41% <ø> (-1.19%) ⬇️
unittests-flytecopilot 11.73% <ø> (-0.45%) ⬇️
unittests-flytectl 62.40% <ø> (?)
unittests-flyteidl 6.89% <ø> (-0.29%) ⬇️
unittests-flyteplugins 53.62% <0.00%> (+0.27%) ⬆️
unittests-flytepropeller 42.84% <ø> (+0.82%) ⬆️
unittests-flytestdlib 54.78% <ø> (-0.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RRap0so RRap0so marked this pull request as ready for review October 22, 2024 09:29
@RRap0so RRap0so changed the title Sync client should call CloseSend when done Sync client should call CloseSend when done sending Oct 22, 2024
Signed-off-by: Rafael Raposo <[email protected]>
Signed-off-by: Rafael Raposo <[email protected]>
@eapolinario eapolinario merged commit 71386f8 into flyteorg:master Oct 22, 2024
49 of 50 checks passed
@Future-Outlier
Copy link
Member

Future-Outlier commented Oct 23, 2024

Just tested it for backward compatibility, thank you @RRap0so

image

@RRap0so RRap0so deleted the grpc-client-agent-close-and-receive branch October 23, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] GRPC Streaming client in agent doesn't CloseSend
4 participants