Make it possible to configure flyte with an externally managed Secret #5700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Hotan <[email protected]>
mhotan
force-pushed
the
mhotan/configurable-secret-name
branch
from
75c3fcb
to
9b7a65c
Compare
mhotan
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5700 +/- ##
=======================================
Coverage 36.17% 36.17%
=======================================
Files 1302 1302
Lines 109614 109614
=======================================
Hits 39653 39653
Misses 65816 65816
Partials 4145 4145
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
davidmirror-ops
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
N/A
Why are the changes needed?
Union manages flyte-core helm release via ArgoCD. We identified that managing the oath client secret was appropriate outside of the flyte-core helm release and, thus, outside of a Git repository watched by ArgoCD. This situation will likely surface for other flyte users. We are thus backporting these changes from Union to Flyte OSS.
How was this patch tested?
This change was tested and release to all Union managed data planes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link