Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump k3s version to 1.29.0 #5475

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Conversation

eapolinario
Copy link
Contributor

Why are the changes needed?

A user on OSS slack mentioned that they were trying to use RestartPolicy to configure an init container, but that field was not behaving properly in the demo cluster.

What changes were proposed in this pull request?

Bump the version of k3s to 1.29.0, which is the first version of k8s that supports that field in an init container.

How was this patch tested?

I built the demo cluster locally (make -C docker/sandbox-bundled build from the root) and used that to kick off the following workflow (notice the use of restart_policy in the init container):

from flytekit import task, workflow, PodTemplate
from kubernetes.client import V1PodSpec, V1Container

@task(
    pod_template=PodTemplate(
        pod_spec=V1PodSpec(
            containers=[
                V1Container(
                    name="primary",
                )
            ],
            init_containers=[
                V1Container(
                    image="alpine",
                    name="init",
                    command=["/bin/sh"],
                    args=["-c", 'echo "I\'m a customizable init container"'],
                    restart_policy="Always",
                )
            ],
        ),
    )
)
def t():
    ...


@workflow
def wf():
    t()

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Eduardo Apolinario <[email protected]>
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.97%. Comparing base (9484e36) to head (e9809cd).
Report is 135 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5475      +/-   ##
==========================================
+ Coverage   60.96%   60.97%   +0.01%     
==========================================
  Files         793      793              
  Lines       51331    51331              
==========================================
+ Hits        31293    31299       +6     
+ Misses      17153    17147       -6     
  Partials     2885     2885              
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.66% <ø> (+0.04%) ⬆️
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 67.97% <ø> (ø)
unittests-flyteidl 79.04% <ø> (ø)
unittests-flyteplugins 61.78% <ø> (ø)
unittests-flytepropeller 57.32% <ø> (ø)
unittests-flytestdlib 65.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wild-endeavor wild-endeavor merged commit 653ca85 into master Jun 13, 2024
51 checks passed
@wild-endeavor wild-endeavor deleted the bump-k3s-version-to-1.29.0 branch June 13, 2024 16:15
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this pull request Jul 2, 2024
Signed-off-by: Eduardo Apolinario <[email protected]>
Co-authored-by: Eduardo Apolinario <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants