Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flytepropeller][flyteadmin] Streaming Decks #5799

Closed
wants to merge 10 commits into from

Conversation

Future-Outlier
Copy link
Member

Tracking issue

#5574

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 67.56757% with 12 lines in your changes missing coverage. Please review.

Project coverage is 37.09%. Comparing base (172e816) to head (1f9dca3).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...lytepropeller/pkg/controller/nodes/task/handler.go 66.66% 10 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5799      +/-   ##
==========================================
+ Coverage   37.04%   37.09%   +0.04%     
==========================================
  Files        1316     1318       +2     
  Lines      132262   132303      +41     
==========================================
+ Hits        48998    49076      +78     
+ Misses      79002    78956      -46     
- Partials     4262     4271       +9     
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.10% <100.00%> (+<0.01%) ⬆️
unittests-flytecopilot 30.99% <ø> (+8.76%) ⬆️
unittests-flytectl 62.29% <ø> (-0.18%) ⬇️
unittests-flyteidl 7.23% <ø> (ø)
unittests-flyteplugins 53.73% <ø> (ø)
unittests-flytepropeller 42.65% <66.66%> (+0.02%) ⬆️
unittests-flytestdlib 57.57% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Future-Outlier and others added 2 commits October 4, 2024 16:42
Signed-off-by: Future-Outlier <[email protected]>
Co-authored-by: pingsutw  <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Co-authored-by: Yicheng-Lu-llll <[email protected]>
@Future-Outlier
Copy link
Member Author

I'll debug this, and switch to the pydantic plugin now.

@Future-Outlier
Copy link
Member Author

It works <3
image

@Future-Outlier Future-Outlier changed the title [wip][flytepropeller][flyteadmin] Streaming Decks [flytepropeller][flyteadmin] Streaming Decks Nov 27, 2024
@Future-Outlier Future-Outlier marked this pull request as ready for review November 27, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant