-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core feature] Rust Flytekit Remote Client #5344
Comments
To address the issues with Python gRPC in the Flytekit remote client, a Rust-based replacement is proposed. This approach aims to eliminate Python gRPC dependencies by using Pyo3 for Python bindings, ensuring seamless integration with Flytekit. A proof of concept is available in this pull request, demonstrating task operations without Python gRPC. The proposed solution includes an remote_rs = FlyteRemote(Config.auto(), default_project="flytesnacks", default_domain="development", enable_rust=True)
flyte_task = remote_rs.register_task(
entity=my_test_task,
serialization_settings=SerializationSettings(
image_config=ImageConfig.auto(img_name="flyte-cr.io/image-name:tag")
),
version="v1"
)
flyte_task = remote_rs.fetch_task(name="task_name", version="v1") Sources: This is an AI-generated response and your feedback is appreciated! Please leave a 👍 if this is helpful and 👎 if it is not. Mention @RunLLM to ask follow-up questions. See runllm.com for more! |
@pingsutw , could you please assist me in adding one more follow-up issue: 'Add secure channel if flyteadmin has SSL enabled'? Thank you! |
Motivation: Why do you think this is important?
The flytekit remote client relies on gRPC for communication with the control plane (FlyteAdmin). However, our experience has revealed numerous issues within Python gRPC, leading to test failures. Additionally, users frequently encounter challenges when working with specific versions of gRPC.
In order to eliminate the gRPC Python dependency from flytekit, our goal is to develop a Rust crate to serve as a replacement for the flytekit remote client. To achieve this, we plan to utilize Pyo3 to generate a Python binding, allowing flytekit to seamlessly integrate and utilize the new implementation.
Goal: What should the final outcome look like, ideally?
flyteorg/flytekit#2377 is a POC of a rust remote client that allows you to get/create tasks without Python grpc
Add a flag (enable_rust) to the FlyteRemote class. When this flag is true, FlyteRemote will use the rust implementation.
Follow up Issues
Describe alternatives you've considered
Use existing flytekit remote client
Propose: Link/Inline OR Additional context
grpcio>=1.59.0
related to grpc thread pool hanging ingrpc_google_default_credentials_create
grpc/grpc#36265Are you sure this issue hasn't been raised already?
Have you read the Code of Conduct?
The text was updated successfully, but these errors were encountered: