[BUG] Removed NotificationsConfig.Region field still referenced

[andrewwdye]

Describe the bug

The NotificationsConfig.Region field is no longer populated by the flyte-core chart template after this change in flyte 1.10; however, this code still assumes it's populated in two places (Emailer, NotificationsProcessor). This causes admin to crash on start when either of these functions are enabled.

As a solution we can either

1. Fully remove NotificationsConfig.Region from its struct and all references to it. This would complete the deprecation and continue on the path of a breaking change that we've already gone down in 1.10
2. Bring back NotificationsConfig.Region and follow a deprecation/removal path in the future

Expected behavior

It's possible to configure Emailer and/or NotificationsProcessor such that admin doesn't crash

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

• Yes

Have you read the Code of Conduct?

• Yes

[adarsh-jha-dev]

Hey @andrewwdye , could you please assign me this issue? I'd like to work on this

[adarsh-jha-dev]

Hey @pingsutw , i have raised a PR regarding this issue, could you please have a look at it and let me know if the changes are relevant ?

[andrewwdye]

Hi @adarsh-jha-dev I forgot to cross reference here, but this was fixed by #4299