Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core feature] Add type transformer for datetime.date #3026

Closed
2 tasks done
dennisobrien opened this issue Oct 25, 2022 · 4 comments
Closed
2 tasks done

[Core feature] Add type transformer for datetime.date #3026

dennisobrien opened this issue Oct 25, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request flytekit FlyteKit Python related issue good first issue Good for newcomers scipy-2023
Milestone

Comments

@dennisobrien
Copy link

Motivation: Why do you think this is important?

Flyte currently does not support the datetime.date object for passing to or from tasks.

ValueError: Type <class 'datetime.date'> not supported currently in Flytekit. Please register a new transformer

In flytekit/core/type_engine.py there are transformers for datetime.datetime and datetime.timedelta, but not for datetime.date.

Goal: What should the final outcome look like, ideally?

Flyte tasks should be able to accept and return datetime.date objects.

Describe alternatives you've considered

The workaround is to use a datetime.datetime or to use a string of the form "YYYY-MM-DD".

Propose: Link/Inline OR Additional context

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@dennisobrien dennisobrien added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Oct 25, 2022
@samhita-alla
Copy link
Contributor

@eapolinario

@eapolinario eapolinario self-assigned this Nov 4, 2022
@eapolinario eapolinario removed the untriaged This issues has not yet been looked at by the Maintainers label Nov 5, 2022
@eapolinario eapolinario added this to the 1.3.0 milestone Nov 5, 2022
@eapolinario eapolinario added the good first issue Good for newcomers label Nov 8, 2022
@eapolinario
Copy link
Contributor

This is a good first issue as it'll touch a few of the components, at least flyteidl (to add the new field) and flytekit.

@eapolinario eapolinario removed their assignment Nov 8, 2022
@cosmicBboy cosmicBboy modified the milestones: 1.3.0, 2023 Q1 Backlog Jan 25, 2023
@cosmicBboy cosmicBboy added scipy-2023 flytekit FlyteKit Python related issue labels Jul 15, 2023
@troychiu
Copy link
Member

troychiu commented Aug 5, 2023

Hi @eapolinario @samhita-alla ,
I am interested in this issue. If you think it still needs to be fixed, feel free to assign it to me.

@pingsutw
Copy link
Member

@dennisobrien FYI. The PR has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request flytekit FlyteKit Python related issue good first issue Good for newcomers scipy-2023
Projects
None yet
Development

No branches or pull requests

6 participants