Add Splunk as a metrics provider #1733
Conversation
Signed-off-by: kane8n <[email protected]>
Signed-off-by: kane8n <[email protected]>
Signed-off-by: kane8n <[email protected]>
Signed-off-by: kane8n <[email protected]>
Signed-off-by: kane8n <[email protected]>
kane8n
force-pushed
the
add-splunk-provider
branch
from
6bdcfb0 to
a4bb1cb
Compare
Signed-off-by: kane8n <[email protected]>
pkg/metrics/providers/splunk.go
Outdated
| flaggerv1 "github.com/fluxcd/flagger/pkg/apis/flagger/v1beta1" | ||
| ) | ||
|
|
||
| // https://docs.datadoghq.com/api/ |
There was a problem hiding this comment.
please change this to splunk's api docs
pkg/metrics/providers/splunk.go
Outdated
|
|
||
| sp := SplunkProvider{ | ||
| timeout: 5 * time.Second, | ||
| metricsQueryEndpoint: strings.Replace(strings.Replace(address+signalFxSignalFlowApiPath, "http", "ws", 1), "api", "stream", 1), |
There was a problem hiding this comment.
could you add some context here?
There was a problem hiding this comment.
The library used to handle the signalflow api uses websockets to connect, so the address is converted.
I've added a COMMENT.
|
|
||
| signalFxTokenHeaderKey = "X-SF-Token" | ||
|
|
||
| signalFxFromDeltaMultiplierOnMetricInterval = 10 |
There was a problem hiding this comment.
could you specify the purpose of this?
There was a problem hiding this comment.
I referred to the datadog implementation.
In some cases, the splunk api could only acquire empty data if the specified period was short, so to ensure that data is acquired, a period 10 times longer than the set interval is used.
| return 0, fmt.Errorf("invalid response: %w", ErrNoValuesFound) | ||
| } | ||
| _payloads := slices.Clone(payloads) | ||
| slices.SortFunc(_payloads, func(i, j messages.DataPayload) int { |
There was a problem hiding this comment.
some comments explaining this logic would be nice
Signed-off-by: kane8n <[email protected]>
|
@aryan9600 |
This PullRequest adds Splunk as a metrics provider.
It has been tested on my cluster.