[shared_preferences] Adds Shared preferences as option in shared preferences async android #7994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan
reviewed
Nov 8, 2024
...roid/android/src/main/kotlin/io/flutter/plugins/sharedpreferences/SharedPreferencesPlugin.kt
Outdated
Show resolved
Hide resolved
tarrinneal
changed the title
tarrinneal
force-pushed
the
shared-preferences-shared-preferences
branch
from
978df17
to
99f76da
Compare
stuartmorgan
requested changes
Nov 22, 2024
...roid/android/src/main/kotlin/io/flutter/plugins/sharedpreferences/SharedPreferencesPlugin.kt
Outdated
Show resolved
Hide resolved
.../shared_preferences/shared_preferences_android/lib/src/shared_preferences_async_android.dart
Outdated
Show resolved
Hide resolved
.../shared_preferences/shared_preferences_android/lib/src/shared_preferences_async_android.dart
Outdated
Show resolved
Hide resolved
packages/shared_preferences/shared_preferences_android/README.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Related to the integration test suggestion, we should have a unit test that writes directly to the default SP store, and then reads it back via backend.
| return SharedPreferencesPigeonOptions(); | ||
| } | ||
|
|
||
| SharedPreferencesAsyncApi _getApiForBackend( | ||
| SharedPreferencesPigeonOptions options) { | ||
| return options.useDataStore ? _dataStoreApi : _sharedPreferencesApi; |
There was a problem hiding this comment.
The use of the same API with different suffixes so you could switch in a single place is very clever!
.../shared_preferences/shared_preferences_android/lib/src/shared_preferences_async_android.dart
Outdated
Show resolved
Hide resolved
.../shared_preferences/shared_preferences_android/lib/src/shared_preferences_async_android.dart
Outdated
Show resolved
Hide resolved
tarrinneal
force-pushed
the
shared-preferences-shared-preferences
branch
from
de43522
to
95eb61e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to select which Android preferences backend (SharedPreferences or DataStore Preferences) one would like to use.
Also adds the ability to pick a file name for the shared preferences backend.
fixes flutter/flutter#153300
fixes flutter/flutter#14337