Skip to content
This repository has been archived by the owner on Mar 15, 2024. It is now read-only.

FlurryAdNativeAsset.loadAssetIntoView() should note that videos should be loaded into a RelativeLayout #5

Open
davidliu opened this issue Oct 30, 2018 · 0 comments

Comments

@davidliu
Copy link

When using loadAssetIntoView for a video, Flurry will add two views to the viewgroup passed into the method. However, due to an internal behavior, one of these views will overwrite its own layout params with a RelativeLayout.LayoutParams in onConfigurationChanged(). Because of this, if the viewgroup passed in is not a RelativeLayout, it will crash whenever configuration changes (e.g. rotation).

I suggest at the very least documenting this behavior within the loadAssetIntoView documentation, but I additionally suggest either enforce runtime checks telling integrating devs of this requirement or getting rid of this behavior altogether.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant