Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install win32-service gem from a forked repository #630

Closed
ashie opened this issue Mar 7, 2024 · 2 comments · Fixed by #631
Closed

Install win32-service gem from a forked repository #630

ashie opened this issue Mar 7, 2024 · 2 comments · Fixed by #631
Assignees
Milestone

Comments

@ashie
Copy link
Member

ashie commented Mar 7, 2024

Until chef/win32-service#85 is merged, we need to install our forked win32-service gem to fix #618 because it's a critical issue on certain environment.
We have already a feature to install fluentd gem from GitHub & local repository.
It would be nice if we add a feature to be able to do it also other gem.
@kenhys Could you take a look this?

@daipom Could you move https://github.com/daipom/win32-service to https://github.com/fluent-plugins-nursery? We need to maintain it by our team, not a person.

@ashie ashie added this to the 5.0.3 milestone Mar 7, 2024
@ashie ashie moved this to LTS WIP in Fluentd Kanban Mar 7, 2024
@daipom
Copy link
Contributor

daipom commented Mar 7, 2024

@daipom Could you move https://github.com/daipom/win32-service to https://github.com/fluent-plugins-nursery? We need to maintain it by our team, not a person.

Sure! I agree!

@daipom
Copy link
Contributor

daipom commented Mar 7, 2024

@daipom Could you move https://github.com/daipom/win32-service to https://github.com/fluent-plugins-nursery? We need to maintain it by our team, not a person.

Sure! I agree!

Transferred to https://github.com/fluent-plugins-nursery/win32-service.

kenhys added a commit to kenhys/fluent-package-builder that referenced this issue Mar 7, 2024
Until chef/win32-service#85 is merged,

This fix should be applied to fluent-package not to block starting fluentdwinsvc service on Windows.

See fluent#618

Closes: fluent#630

Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys added a commit to kenhys/fluent-package-builder that referenced this issue Mar 7, 2024
Until chef/win32-service#85 is merged,

This fix should be applied to fluent-package not to block starting fluentdwinsvc service on Windows.

See fluent#618

Closes: fluent#630

Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys added a commit to kenhys/fluent-package-builder that referenced this issue Mar 7, 2024
Until chef/win32-service#85 is merged,

This fix should be applied to fluent-package not to block starting fluentdwinsvc service on Windows.

See fluent#618

Closes: fluent#630

Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys added a commit to kenhys/fluent-package-builder that referenced this issue Mar 7, 2024
Until chef/win32-service#85 is merged,

This fix should be applied to fluent-package not to block starting fluentdwinsvc service on Windows.

See fluent#618

Closes: fluent#630

Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys added a commit to kenhys/fluent-package-builder that referenced this issue Mar 7, 2024
Until chef/win32-service#85 is merged,

This fix should be applied to fluent-package not to block starting fluentdwinsvc service on Windows.

See fluent#618

Closes: fluent#630

Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys added a commit to kenhys/fluent-package-builder that referenced this issue Mar 11, 2024
Until chef/win32-service#85 is merged,

This fix should be applied to fluent-package not to block starting
fluentdwinsvc service on Windows.

See fluent#618

Closes: fluent#630

NOTE: even though just putting the following line
does not install forked version of win32-service, so
install it explicitly as same as fluentd gem.

  gem "win32-service", github: "fluent-plugins-nursery/win32-service", branch: "fluent-package", platforms: [:mingw, :x64_mingw]

Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys added a commit to kenhys/fluent-package-builder that referenced this issue Mar 12, 2024
Until chef/win32-service#85 is merged,

This fix should be applied to fluent-package not to block starting
fluentdwinsvc service on Windows.

See fluent#618

Closes: fluent#630

NOTE: even though just putting the following line
does not install forked version of win32-service, so
install it explicitly as same as fluentd gem.

  gem "win32-service", github: "fluent-plugins-nursery/win32-service",
  branch: "fluent-package", platforms: [:mingw, :x64_mingw]

Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys added a commit to kenhys/fluent-package-builder that referenced this issue Mar 12, 2024
Until chef/win32-service#85 is merged,
use forked version of win32-service.

This fix should be applied to fluent-package not to block starting
fluentdwinsvc service on Windows.

See fluent#618

Closes: fluent#630

NOTE: even though just putting the following line
does not install forked version of win32-service, so
install it explicitly as same as fluentd gem.

  gem "win32-service", github: "fluent-plugins-nursery/win32-service",
  branch: "fluent-package", platforms: [:mingw, :x64_mingw]

Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys added a commit to kenhys/fluent-package-builder that referenced this issue Mar 13, 2024
Until chef/win32-service#85 is merged,
use forked version of win32-service.

This fix should be applied to fluent-package not to block starting
fluentdwinsvc service on Windows.

See fluent#618

Closes: fluent#630

NOTE: even though just putting the following line
does not install forked version of win32-service, so
install it explicitly as same as fluentd gem.

  gem "win32-service", github: "fluent-plugins-nursery/win32-service",
  branch: "fluent-package", platforms: [:mingw, :x64_mingw]

Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys added a commit to kenhys/fluent-package-builder that referenced this issue Mar 13, 2024
Until chef/win32-service#85 is merged,
use forked version of win32-service.

This fix should be applied to fluent-package not to block starting
fluentdwinsvc service on Windows.

See fluent#618

Closes: fluent#630

NOTE: even though just putting the following line
does not install forked version of win32-service, so
install it explicitly as same as fluentd gem.

  gem "win32-service", github: "fluent-plugins-nursery/win32-service",
  branch: "fluent-package", platforms: [:mingw, :x64_mingw]

Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys added a commit to kenhys/fluent-package-builder that referenced this issue Mar 13, 2024
Until chef/win32-service#85 is merged,
use forked version of win32-service.

This fix should be applied to fluent-package not to block starting
fluentdwinsvc service on Windows.

See fluent#618

Closes: fluent#630

NOTE: even though just putting the following line
does not install forked version of win32-service, so
install it explicitly as same as fluentd gem.

  gem "win32-service", github: "fluent-plugins-nursery/win32-service",
  branch: "fluent-package", platforms: [:mingw, :x64_mingw]

Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys added a commit to kenhys/fluent-package-builder that referenced this issue Mar 13, 2024
Until chef/win32-service#85 is merged,
use forked version of win32-service.

This fix should be applied to fluent-package not to block starting
fluentdwinsvc service on Windows.

See fluent#618

Closes: fluent#630

NOTE: even though just putting the following line
does not install forked version of win32-service, so
install it explicitly as same as fluentd gem.

  gem "win32-service", github: "fluent-plugins-nursery/win32-service",
  branch: "fluent-package", platforms: [:mingw, :x64_mingw]

Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys added a commit to kenhys/fluent-package-builder that referenced this issue Mar 13, 2024
Until chef/win32-service#85 is merged,
use forked version of win32-service.

This fix should be applied to fluent-package not to block starting
fluentdwinsvc service on Windows.

See fluent#618

Closes: fluent#630

NOTE: even though just putting the following line
does not install forked version of win32-service, so
install it explicitly as same as fluentd gem.

  gem "win32-service", github: "fluent-plugins-nursery/win32-service",
  branch: "fluent-package", platforms: [:mingw, :x64_mingw]

Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys added a commit to kenhys/fluent-package-builder that referenced this issue Mar 13, 2024
Until chef/win32-service#85 is merged,
use forked version of win32-service.

This fix should be applied to fluent-package not to block starting
fluentdwinsvc service on Windows.

See fluent#618

Closes: fluent#630

NOTE: even though just putting the following line
does not install forked version of win32-service, so
install it explicitly as same as fluentd gem.

  gem "win32-service", github: "fluent-plugins-nursery/win32-service",
  branch: "fluent-package", platforms: [:mingw, :x64_mingw]

Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys added a commit that referenced this issue Mar 13, 2024
Until chef/win32-service#85 is merged,
use forked version of win32-service.

This fix should be applied to fluent-package not to block starting
fluentdwinsvc service on Windows.

See #618

Closes: #630

NOTE: even though just putting the following line
does not install forked version of win32-service, so
install it explicitly as same as fluentd gem.

```
  gem "win32-service", github: "fluent-plugins-nursery/win32-service",
  branch: "fluent-package", platforms: [:mingw, :x64_mingw]
```

Signed-off-by: Kentaro Hayashi <[email protected]>
@github-project-automation github-project-automation bot moved this from LTS WIP to Done in Fluentd Kanban Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants