Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: default cri parser does not output time field due to missing Time_Keep parameter #957

Closed
JoeDerby opened this issue Oct 12, 2023 · 0 comments · Fixed by #958
Closed

Comments

@JoeDerby
Copy link
Contributor

JoeDerby commented Oct 12, 2023

Describe the issue

A fix was applied to the fluent-bit repo in fluent/fluent-bit#3085 has not been completed in fluent-operator, the parameter exists in the other default parsers.
'The default parsers.conf cri parser is missing Time_Keep setting.'

Fluent Operator default cri parser https://github.com/fluent/fluent-operator/blob/master/conf/parsers.conf#L125

[PARSER]
    # http://rubular.com/r/tjUt3Awgg4
    Name cri
    Format regex
    Regex ^(?<time>[^ ]+) (?<stream>stdout|stderr) (?<logtag>[^ ]*) (?<message>.*)$
    Time_Key    time
    Time_Format %Y-%m-%dT%H:%M:%S.%L%z

Fluent Bit default cri parser https://github.com/fluent/fluent-bit/blob/master/conf/parsers.conf#L114

[PARSER]
    # http://rubular.com/r/tjUt3Awgg4
    Name cri
    Format regex
    Regex ^(?<time>[^ ]+) (?<stream>stdout|stderr) (?<logtag>[^ ]*) (?<message>.*)$
    Time_Key    time
    Time_Format %Y-%m-%dT%H:%M:%S.%L%z
    Time_Keep   On

To Reproduce

Use the default cri parser for parsing logs with the operator ClusterFluentBitConfig resource.

Expected behavior

Expect the default cri parser to keep the time field.

How did you install fluent operator?

via Helm

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant