Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scheme parameter to fluentd-output-opensearch.yaml #579

Closed
kaiohenricunha opened this issue Feb 16, 2023 · 2 comments · Fixed by #949
Closed

Add scheme parameter to fluentd-output-opensearch.yaml #579

kaiohenricunha opened this issue Feb 16, 2023 · 2 comments · Fixed by #949
Labels
good first issue Good for newcomers

Comments

@kaiohenricunha
Copy link
Contributor

kaiohenricunha commented Feb 16, 2023

Is your feature request related to a problem? Please describe.

I noticed the fluentd-output-opensearch resource doesn't render scheme parameter as it does with host and port, for example. This is because it is included in the CRD, but not in the template.

Describe the solution you'd like

Include scheme validation on fluentd-output-opensearch.yaml template.

Additional context

No response

@benjaminhuo benjaminhuo added the good first issue Good for newcomers label Feb 17, 2023
@benjaminhuo
Copy link
Member

@kaiohenricunha It'll be great if you can create a PR for this!

@jynolen
Copy link
Contributor

jynolen commented Apr 7, 2023

Can you give a bit more context ?
Is it related to Helm Chart / Configuration of the CRD / Result of the defintion ?

If you are able to provides snippet of what you are trying to do it could be great for us to reproduce.

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants