Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Time_System_Timezone parser option docs #1388

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

braydonk
Copy link
Contributor

@braydonk braydonk commented Jun 4, 2024

This PR adds documentation for the proposed Time_System_Timezone configuration option.

Related PR: fluent/fluent-bit#8164

@braydonk braydonk requested review from a team as code owners June 4, 2024 14:45
@patrick-stephens
Copy link
Contributor

@braydonk I presume we don't hit the usual issue with timezones not set in container images? What's the process it uses to get the default timezone (e.g. across OS/containers)?

@braydonk
Copy link
Contributor Author

braydonk commented Jun 4, 2024

Under the hood the feature uses the mktime function from libc, which under the hood uses the POSIX TZ environment variable. This should work on all platforms Fluent Bit supports (including Windows in my testing), but I'm not sure about containers. I don't know if there is anything that Fluent Bit should be expected to do if the TZ env var isn't set properly though.

Should I add this to the table entry here in the docs? Specifically I'd mention the TZ environment variable. EDIT: Decided to add that.

@patrick-stephens
Copy link
Contributor

Yeah, it's a known issue sometimes that TZ may not be set or imported from the host, etc.

@braydonk
Copy link
Contributor Author

braydonk commented Jun 27, 2024

The feature was merged in fluent/fluent-bit#9006. This PR should be good to be merged now.

@patrick-stephens
Copy link
Contributor

Is it in a release @braydonk, that's the normal gate rather than just a merge even though the label suggests otherwise :)

@lecaros lecaros merged commit 11070df into fluent:master Jun 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants