Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change image format for tests #16

Open
flrs opened this issue Jul 15, 2019 · 2 comments
Open

Change image format for tests #16

flrs opened this issue Jul 15, 2019 · 2 comments

Comments

@flrs
Copy link
Owner

flrs commented Jul 15, 2019

The currently used "PNG" format is not lossless and therefore might influence the quality of the tests. For example, if a prepared test image is exported from GIMP for comparison with blend_modes' image blending method, the image might already be changed during the export process.

To avoid this problem, a lossless format should be used, for example TIFF. The format needs to be fully compatible with the library used for importing images into Python (currently opencv-python).

@MadsDyrmann
Copy link

I think you confuse the two formats. PNG is always lossless, whereas TIFF can be lossless, but often isn't. -- It depends on which compression method you select when exporting the TIFF image.

@flrs
Copy link
Owner Author

flrs commented Nov 14, 2019

Alright, thank you for the explanation. Whatever we make of this issue, we should enforce a lossless format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants