Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change API for sendMessageRaw on CommandSender to have ChatReceiver #2

Open
Zidane opened this issue Jul 10, 2014 · 2 comments
Open

Comments

@Zidane
Copy link

Zidane commented Jul 10, 2014

Would be nice to always have the ChatReceiver parameter in the sendMessageRaw method (one of the other two sendMessage messages has it). If null is passed in to it, that's fine as its up to lib users to handle what happens in that situation.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@Zidane Zidane changed the title Change API for sendMessage on CommandSender to always have ChatReceiver Change API for sendMessageRaw on CommandSender to have ChatReceiver Jul 10, 2014
@Zidane
Copy link
Author

Zidane commented Jul 10, 2014

To clarify

tl;dr I just want sendMessageRaw(ChatReceiver from, String message)

@Wolf480pl
Copy link
Contributor

The plan was that there's some pattern/format mechanism (coming "soon") called in ChatReceiver.sendMessage(ChatReceiver,String) and ChatChannel.broadcast(ChatReceiver,String) and uses something like "<{sender}> {msg}" to create the message that will be sent to the client via sendMessageRaw.

But now that I think of it, it might be a good idea to pass the sender further. What's exactly your use case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants