TASK: Improve flushByTags performance #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In my test environment, the optimized method saves about 30 seconds when publishing a page with ~300 nodes. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
============================================
- Coverage 26.81% 26.28% -0.53%
- Complexity 138 140 +2
============================================
Files 2 2
Lines 399 407 +8
============================================
Hits 107 107
- Misses 292 300 +8
☔ View full report in Codecov by Sentry. |
This backports the optimized code from the redis backend of the neos/cache package. (https://github.com/neos/flow-development-collection/blob/8.3/Neos.Cache/Classes/Backend/RedisBackend.php#L297)
daniellienert
force-pushed
the
task/improve-flushByTags-perfoemance
branch
from
11401dd to
fcdc3d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports the optimized code from the redis backend of the neos/cache package. (https://github.com/neos/flow-development-collection/blob/8.3/Neos.Cache/Classes/Backend/RedisBackend.php#L297)