Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French Cleat edge stud can clash with cleat #731

Open
AlexCPU opened this issue Dec 9, 2024 · 1 comment
Open

French Cleat edge stud can clash with cleat #731

AlexCPU opened this issue Dec 9, 2024 · 1 comment
Labels

Comments

@AlexCPU
Copy link
Contributor

AlexCPU commented Dec 9, 2024

Describe the bug
French Cleat settings don't ask for the height of the cleat, so can generate the stud where there isn't space on the wall

Screenshots or Drawings
image

To Reproduce
The French Cleat Settings requests the depth (green in fig.), and the spacing (purple in fig.), but doesn't request the height (blue in fig.) of the cleats, so this means that in stud mode (the default and likely most common), studs can be created in studs that they don't fit.

Expected behaviour
For holders smaller than a cleat, omit the stud.
For holders bigger than a cleat, move the stud up if it would collide with a cleat.

Additional context
I'll have a go at fixing this soon, but I've got a couple of generators I want to try first.

@AlexCPU AlexCPU added the bug label Dec 9, 2024
@florianfesti
Copy link
Owner

Yeah, the stud implementation is pretty simple - not to say brain dead. Probably result of me not having an actual French cleat wall. A patch is very welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants