Go sharded client #43
Conversation
kingster
force-pushed
the
go-shared-client
branch
from
e16d9ec to
48f16d2
Compare
clients/go/dkv/client.go
Outdated
| return m, nil | ||
| } | ||
|
|
||
| type SimpleDKVClient struct { |
There was a problem hiding this comment.
Please provide a public API(s) for initializing instances of this struct
There was a problem hiding this comment.
Made this private. There is already an existing api to create ctl.NewInSecureDKVClient(....)
clients/go/dkv/client.go
Outdated
| BufferItems: 64, | ||
| OnExit: func(val interface{}) { | ||
| client := val.(*SimpleDKVClient) | ||
| log.Printf("Closing Client of %s \n", client.Addr) |
There was a problem hiding this comment.
Given that Addr has this only logging usage here, please check if this log statement is needed. Or check if this can be logged from inside client.Close() itself.
clients/go/dkv/client.go
Outdated
|
|
||
| type ShardProvider interface { | ||
| ProvideShard(key []byte) (*DKVShard, error) | ||
| ProvideShards(keys ...[]byte) (map[*DKVShard][][]byte, error) |
There was a problem hiding this comment.
Given that the key used in the returned map is a pointer, only pointer equality is considered. In other words, the underlying DKVShard equality is never considered. Please check this.
There was a problem hiding this comment.
Refactored it to return slice of DKVKeyGroup
clients/go/dkv/client.go
Outdated
| shards []DKVShard | ||
| } | ||
|
|
||
| func NewShardedDKVClient(shardProvider ShardProvider) (*ShardedDKVClient, error) { |
There was a problem hiding this comment.
Please validate if the shardProvider is actually given.
clients/go/dkv/client.go
Outdated
| for _, serverRole := range role { | ||
| nodeSet, err = shard.GetNodesByType(serverRole) | ||
| if err == nil { | ||
| return nodeSet, err |
There was a problem hiding this comment.
Please use return nil, err
There was a problem hiding this comment.
This is an early return, breaks out of the iteration by returning nodeSet
kingster
force-pushed
the
go-shared-client
branch
7 times, most recently
from
be8fe95 to
e6ea193
Compare
kingster
force-pushed
the
go-shared-client
branch
from
809fdf2 to
780db31
Compare
Implements the sharded go-client #40