Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CX parser can't locate search fields #55

Open
asgillmor opened this issue Jul 30, 2019 · 5 comments
Open

CX parser can't locate search fields #55

asgillmor opened this issue Jul 30, 2019 · 5 comments

Comments

@asgillmor
Copy link

The elements in the DOM look very different than what is described in the parser for the page given.

Error: No node found for selector: #input-origin
    at assert (/Users/alex/.nvm/versions/node/v11.15.0/lib/node_modules/flightplan-tool/node_modules/puppeteer/lib/helper.js:270:11)
    at DOMWorld.click (/Users/alex/.nvm/versions/node/v11.15.0/lib/node_modules/flightplan-tool/node_modules/puppeteer/lib/DOMWorld.js:366:5)
    at processTicksAndRejections (internal/process/task_queues.js:86:5)
  -- ASYNC --
    at Frame.<anonymous> (/Users/alex/.nvm/versions/node/v11.15.0/lib/node_modules/flightplan-tool/node_modules/puppeteer/lib/helper.js:111:15)
    at Page.click (/Users/alex/.nvm/versions/node/v11.15.0/lib/node_modules/flightplan-tool/node_modules/puppeteer/lib/Page.js:1031:29)
    at module.exports.setCity (/Users/alex/.nvm/versions/node/v11.15.0/lib/node_modules/flightplan-tool/src/engines/cx/searcher.js:308:16)
    at module.exports.search (/Users/alex/.nvm/versions/node/v11.15.0/lib/node_modules/flightplan-tool/src/engines/cx/searcher.js:60:16)
[CX] DEPARTURE [HKG -> SFO] - 2020-01-01 (2 Passengers)
@jd20
Copy link
Collaborator

jd20 commented Jul 31, 2019

It's likely the website HTML has changed quite a bit since the last update to the CX parser. Feel free to submit a PR to bring it up to date.

@asgillmor
Copy link
Author

Okay! I'll probably submit one for Aeroplan first because the fix there was trivial.

The CX markup has become very react-ified and a bit more difficult, I'll take a look.

@dingwa
Copy link

dingwa commented Jan 19, 2020

Any ideas on how best to get CX website working again? I've made a feeble attempt at getting the updated website working however to no avail

@byteofmydream
Copy link

I updated selectors for CX website in this PR: #72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants