Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete nifti not working properly #2502

Open
jcomedouteau opened this issue Nov 15, 2024 · 1 comment · May be fixed by #2534
Open

Delete nifti not working properly #2502

jcomedouteau opened this issue Nov 15, 2024 · 1 comment · May be fixed by #2534
Assignees
@michaelkain
Labels
WorkInProgress

Comments

@jcomedouteau
Copy link
Collaborator

Two things:

  • When deleting all nifti of a very big study, the request takes too much time. We should do it asynchroneously. (see with @pierrehenri-dauvergne on how to do it)
  • We sometimes encounter the following error:
    "Row was updated or deleted by another transaction (or unsaved-value mapping was incorrect) : [org.shanoir.ng.dataset.model.DatasetExpression#1790168]",
    (example for study id 23 on ofsep quailf)

This may be linked to the fact that we are working with a List and not a Set<>, but I'm not quite sure. Ne need to test it further.
@jcomedouteau jcomedouteau mentioned this issue Nov 18, 2024
Open
DuckflipXYZ added a commit to DuckflipXYZ/shanoir-ng that referenced this issue Dec 6, 2024
@DuckflipXYZ
fli-iam#2502 : mass nifti deletion update
3135b8e
DuckflipXYZ added a commit to DuckflipXYZ/shanoir-ng that referenced this issue Dec 6, 2024
@DuckflipXYZ
fli-iam#2502 : mass nifti deletion update
7e6886e
DuckflipXYZ added a commit to DuckflipXYZ/shanoir-ng that referenced this issue Dec 6, 2024
@DuckflipXYZ
fli-iam#2502 : mass nifti deletion update
1600cd8
DuckflipXYZ added a commit to DuckflipXYZ/shanoir-ng that referenced this issue Dec 6, 2024
@DuckflipXYZ
fli-iam#2502 : mass nifti deletion update
c448a54
DuckflipXYZ added a commit to DuckflipXYZ/shanoir-ng that referenced this issue Dec 9, 2024
@DuckflipXYZ
fli-iam#2502 : Nifti deletion event add to job display filter
81ebd3f
DuckflipXYZ added a commit to DuckflipXYZ/shanoir-ng that referenced this issue Dec 9, 2024
@DuckflipXYZ
fli-iam#2502 : Nifti deletion event added to job display filter
c715499
DuckflipXYZ added a commit to DuckflipXYZ/shanoir-ng that referenced this issue Dec 9, 2024
@DuckflipXYZ
fli-iam#2502 : partition transactions wait the previous to end before…
0766f19 
… starting
@DuckflipXYZ DuckflipXYZ linked a pull request Dec 16, 2024 that will close this issue
#2502 : mass nifti deletion update #2534
Open
@DuckflipXYZ
Copy link
Collaborator

Seems good but keep in mind that I had to talk to Anthony about the server memory issue, after what he gave more resources to the database container (or something like, I'm not sure), it gonna be required on prod too (probably).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelkain michaelkain

Labels
WorkInProgress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2502 : mass nifti deletion update DuckflipXYZ/shanoir-ng
3 participants
@michaelkain @jcomedouteau @DuckflipXYZ