-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenBSD support #141
Add OpenBSD support #141
Conversation
I'm not sure All other examples show |
https://github.com/kolargol/openvpn/blob/58ff7985cbb4c75153650435393dc8886be07378/openvpn.yml#L14 |
@postmodern Thank you for submitting this! I just kicked off CI. |
The macos failures are related to the macos-14 defaults that github started using, I'll fix those in a separate PR. Edit: that PR is #142. |
1f6a3bb
to
9d5a69e
Compare
I've rebased onto |
Adding more packages and using gmake in a commit I just appended. |
Added a commit that I think will fix the cmake tests ... still failing on some pkg-config edge cases we need to look into. Edit: removed that commit from the PR because it didn't work. |
8c2abef
to
288062f
Compare
Really struggling here ... and the long feedback loops (because timeout tests are taking 2.5 minutes for each retry) are not making it easy. I'm going to try to reduce timeouts so that I can then have faster feedback loops to try to fix the remaining failing tests. |
c7115b1
to
ee0daea
Compare
@postmodern OK, I'm timing out on this for now. Things going on in this PR in CI:
|
It might be a good idea to test against bsdmake, which is a bit more limited than GNU make.
Are we sure
I also get random |
The issue I was addressing is that the libraries we're using as test subjects (e.g., libyaml) are not compatible with BSD's make, so we need to work around that.
I chatted with Stan in #130 and I'm going to try to write a PR that uses RbConfig to determine the compilers, and this whole problem with the CMake detection may go away. I'll try to get to that this week.
Yes, the test suite intentionally exercises the methods with simulated network failures. The problem is that on most platforms, the timeouts are fast and on openbsd for some reason they're very slow (2.5 minutes each x 3 retries). |
ee0daea
to
23f3549
Compare
I've rebased this branch onto the branch from #144 which I think will fix the CMake test failures. |
* OpenBSD's `tar` does not support the `-J` flag, thus we must use `xzcat $file | tar xf - -C $dest` to first uncompress the `.tar.xz` file and pipe it into `tar` to then extract it.
also add more packages: cmake, git, pkgconf, gnupg
23f3549
to
4d789d1
Compare
Rebased once more, should be easier to see failures now. |
Added a commit: |
openbsd's pkg-config doesn't support `--print-variables`, but we don't need it since everybody's pkg-config seems to just return a blank string if the variable doesn't exist.
4c0ebe7
to
68f8344
Compare
tar
not supporting the-J
option by usingxzcat $file | tar xf - -C $dest
.