Create release binary with cmake explicitly #136
Conversation
Watson1978
force-pushed
the
release-build
branch
from
fe95317 to
fe56918
Compare
|
@Watson1978 Thank you for submitting this pull request and updating the tests! I'm not a CMake user, so I want to check with one other person who's contributed improvements to CMake: @stanhu what do you think of default to |
|
Default to It would be nice to configure this in order to see backtraces, but I suppose that could also be done by adding |
|
@stanhu Thanks for the fast feedback. I'm going to add a config param / env var override like mini_portile already provides for the cmake command. |
- default to "Release" - allow :cmake_build_type kwarg to the constructor - override everything with CMAKE_BUILD_TYPE env var
|
@stanhu @Watson1978 would love feedback on the commit I appended |
|
Looks good to me, thanks! |
|
@flavorjones Thank you for your improvement. Looks good to me! |
|
I'll make time to cut a release in the next day or two. |
|
thanks!! |
|
@flavorjones Thanks for this! Could you cut a release? |
|
@stanhu Thanks for the poke. I'm traveling this week and it's been challenging to find time. I delayed because I was nervous about the not-fully baked pkgconfig feature on main, but will just pull the trigger. Expect a release tomorrow. |
I'll take a look in the context of mudge/re2#109. |
This update builds abseil-cpp in Release mode (flavorjones/mini_portile#136). For the x86_64 shared object, it appears that this shrinks `re2.so`from 2766744 bytes to 1506992 bytes, a 45% reduction.
This update builds abseil-cpp in Release mode (flavorjones/mini_portile#136). For the x86_64 shared object, it appears that this shrinks `re2.so`from 2766744 bytes to 1506992 bytes, a 45% reduction.
When I built library with the default setting, its compilation has no optimized in my environment.
I want it has release binary by default.
Ref. https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html