Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider removing support for older rubies #123

Open
flavorjones opened this issue Dec 24, 2022 · 3 comments
Open

consider removing support for older rubies #123

flavorjones opened this issue Dec 24, 2022 · 3 comments

Comments

@flavorjones
Copy link
Owner

It's getting hard to support old rubies, see failing test suites here related to setup-ruby and bundler versions:

https://github.com/flavorjones/mini_portile/actions/runs/3771621986/jobs/6412111557

I'd like to consider dropping support for ruby < 2.6 in the next minor release.

@halostatue
Copy link

Still worth considering. minitar v1 has been released and only supports Ruby 3.1 or later. There shouldn't be any other changes required since you are not using the Archive::Tar namespace.

@flavorjones
Copy link
Owner Author

@halostatue Thanks for that context! I've only not-removed support because it hasn't bitten me since I opened this ticket. 🍀 It's only a matter of "when" we drop support, not "if". ❤️

@halostatue
Copy link

Yeah. I’m getting ready to go through a similar upgrade process for most of my maintained gems, although I probably won't be cutting them "hard" like I have done with minitar (that is, when I cut mime-types 4, I will continue to maintain mime-types 3 for some time to come, but new features will not show up in mime-types 3; same with diff-lcs 2 vs diff-lcs 1).

I need to open a discussion on ruby-core to get some advice from yjit developers so I can examine these for ways to ensure that these gems are easier to optimize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants