Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove transient permissions after 24h #990

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Commits on Mar 7, 2023

  1. screencast: Wrap transient permission in a struct

    We'll soon have to store more than just the GVariant, so in
    preparation for that, store the variant in a custom struct,
    and proxy that variant when retrieving the transient permission.
    GeorgesStavracas committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    5aedb71 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2023

  1. meson: Depend on glib >= 2.56

    This is really old and available in Ubuntu 18.04 (!) so since we're
    going to start using functions from that version, might as well
    declare that in the build system.
    GeorgesStavracas committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    3af26bd View commit details
    Browse the repository at this point in the history
  2. screencast: Warn about removing non-existing permissions

    This should never normally trigger, but seems like a good warning
    to have. We can't print the permission id, as that could leak the
    token in the journal log.
    GeorgesStavracas committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    09b2ed0 View commit details
    Browse the repository at this point in the history
  3. screencast: Expire transient permissions after a day

    This comes after a recent discussion. Transient permissions are
    modeled mainly towards browsers who have to do IPC and cannot
    share the PipeWire node directly. Instead, they can request a
    transient permission that allows restoring the stream that one
    process requested, but without granting the browser "eternal"
    access to that stream subsequently.
    
    However, an oversight of the original implementation was the
    case where we grant the permission, but the app stays open for
    very long times, which is fairly common when it comes to browsers.
    
    Expire transient permission tokens after 24 hours have passed.
    
    Closes flatpak#981
    GeorgesStavracas committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    5913a78 View commit details
    Browse the repository at this point in the history