Remove transient permissions after 24h #990
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll soon have to store more than just the GVariant, so in preparation for that, store the variant in a custom struct, and proxy that variant when retrieving the transient permission.
This is really old and available in Ubuntu 18.04 (!) so since we're going to start using functions from that version, might as well declare that in the build system.
This should never normally trigger, but seems like a good warning to have. We can't print the permission id, as that could leak the token in the journal log.
This comes after a recent discussion. Transient permissions are modeled mainly towards browsers who have to do IPC and cannot share the PipeWire node directly. Instead, they can request a transient permission that allows restoring the stream that one process requested, but without granting the browser "eternal" access to that stream subsequently. However, an oversight of the original implementation was the case where we grant the permission, but the app stays open for very long times, which is fairly common when it comes to browsers. Expire transient permission tokens after 24 hours have passed. Closes flatpak#981
|
Soft depends on #977 (I didn't even bother changing Autotools) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and as long as the app is running.
Draft because Chromium seems still be able to restore this token, despite it bring dropped (!) - you can verify that by changing the timeout to, say, 5 seconds.
@grulja do you know why is that?