Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: metrics updates #1231

Merged
merged 1 commit into from
Dec 6, 2024
Merged

fix: metrics updates #1231

merged 1 commit into from
Dec 6, 2024

Conversation

adityathebe
Copy link
Member

@adityathebe adityathebe commented Dec 6, 2024 •
edited
Loading

  • added scraper_delete metrics
  • use shared informers for deleted objects

resolves: #1229

adityathebe
adityathebe commented Dec 6, 2024
View reviewed changes
cmd/operator.go Outdated Show resolved Hide resolved
moshloop
moshloop reviewed Dec 6, 2024
View reviewed changes
utils/kube/fetcher.go Outdated Show resolved Hide resolved
@moshloop moshloop enabled auto-merge (squash) December 6, 2024 09:05
@adityathebe adityathebe disabled auto-merge December 6, 2024 09:07
@adityathebe adityathebe force-pushed the fix/metrics-updates branch 2 times, most recently from d73fb20 to 7c3c491 Compare December 6, 2024 09:22
@adityathebe adityathebe enabled auto-merge (rebase) December 6, 2024 09:25
@adityathebe adityathebe merged commit 142a975 into main Dec 6, 2024
9 checks passed
@adityathebe adityathebe deleted the fix/metrics-updates branch December 6, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moshloop moshloop moshloop left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metric updates
2 participants
@adityathebe @moshloop