Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure config type - Do not uppercase #316

Closed
moshloop opened this issue Nov 26, 2023 · 2 comments
Closed

Azure config type - Do not uppercase #316

moshloop opened this issue Nov 26, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@moshloop
Copy link
Member

No description provided.

@moshloop moshloop added the bug Something isn't working label Nov 26, 2023
@adityathebe
Copy link
Member

@moshloop I think this was a necessity. Take a look at this comment.

// getARMType takes in a type of a resource group
// and returns it in a compatible format.
func getARMType(rType *string) string {
// Need to uppercase the resource type in the config item because
// the azure advisor recommendation uses resource type in all uppercase; not always but most of the time.
// For example: It returns
// - MICROSOFT.COMPUTE/VIRTUALMACHINES (all caps)
// - Microsoft.ContainerService/ManagedClusters (case not enforced)
// This is required to match config analysis with the config item.
return "Azure::" + strings.ToUpper(deref(rType))
}

@adityathebe
Copy link
Member

#328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants