-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Flang2] Fix duplicate TBAA type systems across modules #1460
Open
1997alireza
wants to merge
1
commit into
flang-compiler:master
Choose a base branch
from
1997alireza:fix-tbaa-duplicate
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+74
−4
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
! A part of the test provided in tbaa_multimod_01_caller.f90 | ||
! Empty RUN and CHECK to prevent error | ||
! RUN: echo "NoCheck" | FileCheck %s | ||
! CHECK: NoCheck | ||
subroutine modify1(arr) | ||
implicit none | ||
real, intent(inout) :: arr(:) | ||
arr(0) = arr(0) + 0.5 | ||
end subroutine modify1 | ||
|
||
subroutine modify2(arr) | ||
implicit none | ||
real, intent(inout) :: arr(:) | ||
arr(2) = arr(2) + 1.5 | ||
end subroutine modify2 | ||
|
||
subroutine printout(arr) | ||
implicit none | ||
real, intent(in) :: arr(:) | ||
integer :: i | ||
do i = 1, size(arr) | ||
print arr(i), " " | ||
enddo | ||
end subroutine printout |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
! This test contians two files, tbaa_multimod_01_caller.f90 and tbaa_multimod_01_callee.f90 | ||
! RUN: %flang -Wl,-mllvm,-aa-trace -fuse-ld=llvm-lto -flto=full -O3 %s %S/tbaa_multimod_01_callee.f90 -o - 2>&1 1>- | FileCheck %s | ||
! CHECK: End ptr getelementptr (%struct.BSS1, ptr @.BSS1, i64 -1, i32 0, i64 16) @ LocationSize::precise(16), ptr inttoptr (i64 56 to ptr) @ LocationSize::precise(8) = MayAlias | ||
|
||
program main | ||
implicit none | ||
integer, parameter :: n = 5 | ||
real :: arr(n) | ||
integer :: i | ||
i = 0 | ||
arr = 3.2 | ||
arr(i) = 4 | ||
call modify1(arr) | ||
call modify2(arr) | ||
|
||
arr(i) = arr(i) + 2.5 | ||
call printout(arr) | ||
end program main |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
! A part of the test provided in tbaa_multimod_02_caller.f90 | ||
! Empty RUN and CHECK to prevent error | ||
! RUN: echo "NoCheck" | FileCheck %s | ||
! CHECK: NoCheck | ||
subroutine to_load(arr) | ||
implicit none | ||
real, intent(inout) :: arr(:) | ||
real :: var | ||
var = arr(0) | ||
var = var * 2 | ||
print var | ||
end subroutine to_load |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
! This test contians two files, tbaa_multimod_02_caller.f90 and tbaa_multimod_02_callee.f90 | ||
! RUN: %flang -Wl,-mllvm,-aa-trace -fuse-ld=llvm-lto -flto=full -O3 %s %S/tbaa_multimod_02_callee.f90 -o - 2>&1 1>- | FileCheck %s | ||
! CHECK: End ptr getelementptr inbounds (%struct.BSS1, ptr @.BSS1, i64 0, i32 0, i64 16) @ LocationSize::precise(4), ptr inttoptr (i64 56 to ptr) @ LocationSize::precise(8) = MayAlias | ||
|
||
program main | ||
implicit none | ||
integer, parameter :: n = 5 | ||
real :: arr(n) | ||
integer :: i | ||
arr = 1 | ||
call to_load(arr) | ||
arr(0) = 4 | ||
call to_load(arr) | ||
end program main |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All standard headers should be included before custom headers (I apologize if I wasn't clear). And please sort these alphabetically.