Fix build failures when using Clang 19 #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, LLVM 19 installs libomp and libompd under $CMAKE_INSTALL_PREFIX/lib/$LLVM_HOST_TARGET/. This patch updates CMake and llvm-lit configurations to add the new location to the linker and the loader's search paths.
Reduction helpers in the Classic Flang runtime for different data types have different function signatures, yet they are stored in tables with generic types (e.g. void (*)())and are often compared with each other in contexts requiring explicit casts. As of Clang 19, this type of code has resulted in new compile-time warnings. This patch fixes the cases where the generic void (*)() type is not used, and explicit casts are no longer sufficient to silence the compiler.
Wrapper functions exists for the gather/scatter runtime functions which have an additional argument, but the wrappers are used interchangeably with the actual gather/scatter runtime functions. This patch fixes the runtime function types to declare the optional argument, so that the runtime functions and their helpers have the same types.
__abort_sig_hand() resets signal handlers before printing an error message and calling abort(). The code used to set the sa_sigaction field to SIG_DFL, requiring an explicit cast which now causes a warning. It is actually not necessary to use sa_sigaction in this case; setting sa_handler to SIG_DFL is the idiomatic way which also avoids the warning.
This patch fixes the type declaration for file I/O helpers to match those of fread and rwrite.
pawosm-arm
approved these changes
Oct 2, 2024
shivaramaarao
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building Classic Flang with Clang 19, the compiler produces numerous
-Wcast-function-type-mismatchwarnings. Also,libflangrti.sofails to link and tests fail to run, since the OpenMP librarylibomp.sois now installed in a different location by default. This PR fixes these issues, in a way that should be compatible with therelease_18xbranch.